Repository navigation
fix(runs): a re-attach goes on with the turn it was in - #329
Merged
Merged
Conversation
berth run now sends how long its engine has held the card since its last grant or resume, and the new berthd counts the minimum turn from then. Before, every daemon restart reset each holder's min_turn, so a deploy kept waiters out for a full turn again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
A berthd restart, such as a deploy, no longer gives every running engine a fresh minimum turn. Before, a holder
with
min_turn = "5m"showed a full 5m in the TURN column right after each restart, and waiters stayed out forthat long again.
How
berth runremembers when its lease last got the card (the grant, or a resume after a park).held, the seconds since then.where they were.
Proof
TestReattachKeepsTheTurnItWasIn(broker): a re-attach that held 4m of a 5m turn leaves 30s after 30s. Redwithout the fix (
4m30s left).TestReattachGoesOnWithTheTurn(runner, real socket): aberth runwith a 1h turn, berthd stopped after 2s andstarted again. The re-attached lease has less than 59m58s left. Red without the runner change (
59m59.99s).proof.shfull: build, gofmt, vet, tests, Windows build and vet, golangci-lint.